Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(substrait): Update to Substrait v0.53.0 #40

Merged
merged 4 commits into from
Aug 6, 2024
Merged

feat(substrait): Update to Substrait v0.53.0 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
422c85f
chore(substrait): Bump substrait proto version
anshuldata Aug 6, 2024
1969315
Accomodate UserDefined Literal changes where literal value became one…
anshuldata Aug 6, 2024
6b6e542
Fix AdvanceExtension interface to accomodate breaking change in Advan…
anshuldata Aug 6, 2024
4ddc9c9
Add linter ignore directing
anshuldata Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// Package substraitgo contains the experimental go bindings for substrait
// (https://substrait.io).
//
// Current generated proto substrait version: v0.33.0
// Current generated proto substrait version: v0.53.0
package substraitgo

//go:generate buf generate https://github.com/substrait-io/substrait.git#tag=v0.33.0
//go:generate buf generate https://github.com/substrait-io/substrait.git#tag=v0.53.0
8 changes: 5 additions & 3 deletions expr/literals.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// SPDX-License-Identifier: Apache-2.0

//lint:file-ignore SA1019 Using a deprecated function, variable, constant or field

package expr

import (
Expand Down Expand Up @@ -420,7 +422,7 @@

lit.LiteralType = &proto.Expression_Literal_UserDefined_{
UserDefined: &proto.Expression_Literal_UserDefined{
Value: v,
Val: &proto.Expression_Literal_UserDefined_Value{Value: v},

Check warning on line 425 in expr/literals.go

View check run for this annotation

Codecov / codecov/patch

expr/literals.go#L425 

Added line #L425 was not covered by tests
TypeReference: udft.TypeReference,
TypeParameters: params,
},
Expand Down Expand Up @@ -672,7 +674,7 @@
}

return &ProtoLiteral{
Value: v.Value,
Value: v.Val,

Check warning on line 677 in expr/literals.go

View check run for this annotation

Codecov / codecov/patch

expr/literals.go#L677 

Added line #L677 was not covered by tests
Type: &types.UserDefinedType{
Nullability: getNullability(nullable),
TypeReference: v.TypeReference,
Expand Down Expand Up @@ -914,7 +916,7 @@
}

return &ProtoLiteral{
Value: lit.UserDefined.Value,
Value: lit.UserDefined.Val,

Check warning on line 919 in expr/literals.go

View check run for this annotation

Codecov / codecov/patch

expr/literals.go#L919 

Added line #L919 was not covered by tests
Type: &types.UserDefinedType{
Nullability: nullability,
TypeVariationRef: l.TypeVariationReference,
Expand Down
4 changes: 3 additions & 1 deletion plan/plan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// SPDX-License-Identifier: Apache-2.0

//lint:file-ignore SA1019 Using a deprecated function, variable, constant or field

package plan

import (
Expand Down Expand Up @@ -109,7 +111,7 @@ type Version interface {

type AdvancedExtension interface {
GetEnhancement() *anypb.Any
GetOptimization() *anypb.Any
GetOptimization() []*anypb.Any
}

// Plan describes a set of operations to complete. For
Expand Down
Loading
Loading