Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isthmus): allow WindowFunctionConverter to use a non-default TypeConverter #291

Conversation

patientstreetlight
Copy link
Contributor

This to fix #290

Copy link
Member

@bvolpato bvolpato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense 💯 Thanks Chris!

Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. This brings these converters in line with the ScalarFunctionConverter and AggregateFunctionConverter.

@vbarua vbarua merged commit d625648 into substrait-io:main Aug 29, 2024
12 checks passed
@patientstreetlight patientstreetlight deleted the chris.rice/WindowFunctionConverter-custom-TypeConverter branch August 29, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISTHMUS] WindowFunctionConverter should be able to use a non-default TypeConverter
3 participants