Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isthmus): allow WindowFunctionConverter to use a non-default TypeConverter #291

Merged
merged 1 commit into from
Aug 29, 2024
Merged

feat(isthmus): allow WindowFunctionConverter to use a non-default TypeConverter #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions isthmus/src/main/java/io/substrait/isthmus/expression/WindowFunctionConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import io.substrait.expression.WindowBound;
import io.substrait.extension.SimpleExtension;
import io.substrait.isthmus.AggregateFunctions;
import io.substrait.isthmus.TypeConverter;
import io.substrait.type.Type;
import java.util.Collections;
import java.util.List;
Expand Down Expand Up @@ -39,6 +40,14 @@ public WindowFunctionConverter(
super(functions, typeFactory);
}

public WindowFunctionConverter(
List<SimpleExtension.WindowFunctionVariant> functions,
List<FunctionMappings.Sig> additionalSignatures,
RelDataTypeFactory typeFactory,
TypeConverter typeConverter) {
super(functions, additionalSignatures, typeFactory, typeConverter);
}

@Override
protected Expression.WindowFunctionInvocation generateBinding(
WrappedWindowCall call,
Expand Down
9 changes: 9 additions & 0 deletions isthmus/src/main/java/io/substrait/isthmus/expression/WindowRelFunctionConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import io.substrait.expression.WindowBound;
import io.substrait.extension.SimpleExtension;
import io.substrait.isthmus.AggregateFunctions;
import io.substrait.isthmus.TypeConverter;
import io.substrait.relation.ConsistentPartitionWindow;
import io.substrait.type.Type;
import java.util.List;
Expand Down Expand Up @@ -38,6 +39,14 @@ public WindowRelFunctionConverter(
super(functions, typeFactory);
}

public WindowRelFunctionConverter(
List<SimpleExtension.WindowFunctionVariant> functions,
List<FunctionMappings.Sig> additionalSignatures,
RelDataTypeFactory typeFactory,
TypeConverter typeConverter) {
super(functions, additionalSignatures, typeFactory, typeConverter);
}

@Override
protected ConsistentPartitionWindow.WindowRelFunctionInvocation generateBinding(
WrappedWindowRelCall call,
Expand Down
Loading