Ensure the page cannot be shorter than the viewport height #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem to be consistent with how we're doing it in other projects. It seems like there's benefit to be gained from consistency. Should we put this in the component library or adjust the other projects? |
|
🤷🏻 I'm happy to put it in the component library. This is how I've always done it |
thatbudakguy
force-pushed
the
view-height-2
branch
from
af4ce90
to
145da66
Compare
thatbudakguy
force-pushed
the
view-height-2
branch
from
145da66
to
037e6c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1290