Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOLIO barcodes are nil-able and ruby doesn't like sorting strings vs nil #975

Merged
merged 1 commit into from
Jul 14, 2023
Merged

FOLIO barcodes are nil-able and ruby doesn't like sorting strings vs nil #975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/traject/config/sirsi_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2222,10 +2222,12 @@ def holdings(record, context)
end.last if checking_for_ties_holdings.length > 1

# Prefer items with the first volume sort key

holding_with_the_most_recent_shelfkey = callnumber_with_the_most_items.min_by do |holding|
call_number_object = call_number_for_holding(record, holding, context)
[call_number_object.to_volume_sort, holding.barcode]
[call_number_object.to_volume_sort, holding.barcode || '']
end

accumulator << holding_with_the_most_recent_shelfkey.barcode
end

Expand Down