Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to set the thread title #51

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

Prokyonn
Copy link
Member

@Prokyonn Prokyonn commented Dec 11, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #50
Related issues/PRs #issuenum
License MIT
Documentation PR sulu/sulu-docs#prnum

What's in this PR?

Fix for #50

Example Usage

    {{ render(path('sulu_comment.get_threads_comments', {
        threadId: 'page-' ~ uuid,
        referrer: app.request.uri,
        threadTitle: 'This is my title',
        _format: 'html'
    })) }}

To Do

  • Create a documentation PR
  • Update tests

Controller/WebsiteCommentController.php Outdated Show resolved Hide resolved
Twig/CommentFormFactoryTwigExtension.php Outdated Show resolved Hide resolved
Controller/WebsiteCommentController.php Outdated Show resolved Hide resolved
Controller/WebsiteCommentController.php Outdated Show resolved Hide resolved
@Prokyonn Prokyonn force-pushed the bugfix/thread-title branch 2 times, most recently from 9083c82 to b43fa24 Compare December 11, 2023 13:19
@Prokyonn Prokyonn marked this pull request as ready for review December 11, 2023 13:43
@alexander-schranz alexander-schranz changed the title Fix thread title Add possibility to set the thread title Dec 12, 2023
@alexander-schranz alexander-schranz merged commit 62c1224 into sulu:2.x Dec 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThreadTitle is always empty
2 participants