Add possibility to set the thread title

.gitignore

@@ -34,3 +34,5 @@ Tests/Application/.env.test.local
 # php-cs-fixer
 .php-cs-fixer.cache
 php-cs-fixer
+
+.php-version

Controller/WebsiteCommentController.php

@@ -127,7 +127,7 @@ public function cgetCommentsAction(string $threadId, Request $request): Response
         $limit = $request->query->getInt('limit', 10);
         $offset = $request->query->getInt('offset', 0);
 
-        /** @var null|int $pageSize */
+        /** @var int|null $pageSize */
         $pageSize = $request->get('pageSize');
         if ($pageSize) {
             @trigger_deprecation('sulu/comment-bundle', '2.x', 'The usage of the "pageSize" parameter is deprecated.
@@ -170,6 +170,7 @@ public function cgetCommentsAction(string $threadId, Request $request): Response
                 'data_class' => $this->commentClass,
                 'threadId' => $threadId,
                 'referrer' => $referrer,
+                'threadTitle' => $request->query->get('threadTitle'),
             ]
         );
 
@@ -245,7 +246,7 @@ public function postCommentsAction(string $threadId, Request $request): Response
         /** @var CommentInterface $comment */
         $comment = $this->commentRepository->createNew();
 
-        /** @var null|int $parent */
+        /** @var int|null $parent */
         $parent = $request->get('parent');
         if ($parent) {
             $comment->setParent($this->commentRepository->findCommentById($parent));
@@ -270,7 +271,7 @@ public function postCommentsAction(string $threadId, Request $request): Response
         $comment = $form->getData();
 
         /** @var string $threadTitle */
-        $threadTitle = $request->get('threadTitle');
+        $threadTitle = $request->request->get('threadTitle', '');
         $this->commentManager->addComment($type, $entityId, $comment, $threadTitle);
         $this->entityManager->flush();
 
@@ -330,7 +331,7 @@ public function putCommentAction(string $threadId, string $commentId, Request $r
     public function deleteCommentAction(string $threadId, string $commentId, Request $request): Response
     {
         /** @var Comment $comment */
-        $comment = $this->commentRepository->findCommentById(\intval($commentId));
+        $comment = $this->commentRepository->findCommentById((int) $commentId);
 
         $this->entityManager->remove($comment);
         $this->entityManager->flush();
@@ -347,8 +348,8 @@ public function deleteCommentAction(string $threadId, string $commentId, Request
     }
 
     /**
-     * @param null|mixed $data
-     * @param null|string $statusCode
+     * @param mixed|null $data
+     * @param string|null $statusCode
      * @param mixed[] $headers
      *
      * @return View

Entity/CommentRepository.php

@@ -14,6 +14,9 @@
 use Doctrine\ORM\NoResultException;
 use Gedmo\Tree\Entity\Repository\NestedTreeRepository;
 
+/**
+ * @extends NestedTreeRepository<CommentInterface>
+ */
 class CommentRepository extends NestedTreeRepository implements CommentRepositoryInterface
 {
     public function findComments(string $type, string $entityId, int $limit = 10, int $offset = 0): array

Form/Type/CommentType.php

@@ -43,13 +43,14 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
 
         $builder->setAction($this->router->generate('sulu_comment.post_thread_comments', $attributes));
         $builder->add('message', TextareaType::class);
-        $builder->add('threadTitle', HiddenType::class, ['mapped' => false]);
+        $builder->add('threadTitle', HiddenType::class, ['mapped' => false, 'data' => $options['threadTitle']]);
         $builder->add('submit', SubmitType::class);
     }
 
     public function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setRequired('threadId');
+        $resolver->setDefault('threadTitle', '');
         $resolver->setDefault('referrer', null);
         $resolver->setDefault('parent', null);
         $resolver->setDefault('csrf_protection', false);

Resources/doc/getting-started.md

@@ -7,7 +7,8 @@ Following example works for a page:
 ```twig
 {{ render(path('sulu_comment.get_threads_comments', {
     threadId: 'page-' ~ uuid, 
-    referrer: app.request.uri, 
+    referrer: app.request.uri,
+    threadTitle: 'This is my thread title', 
     _format: 'html'
 })) }}
 ```

Tests/Application/config/templates/pages/overview.xml

@@ -5,8 +5,8 @@
 
     <key>overview</key>
 
-    <view>::overview</view>
-    <controller>SuluWebsiteBundle:Default:index</controller>
+    <view>overview</view>
+    <controller>Sulu\Bundle\WebsiteBundle\Controller\DefaultController::indexAction</controller>
     <cacheLifetime>2400</cacheLifetime>
 
     <properties>

Tests/Application/templates/overview.html.twig

@@ -0,0 +1,13 @@
+{% extends 'master.html.twig' %}
+
+
+{% block content %}
+
+    {{ render(path('sulu_comment.get_threads_comments', {
+        threadId: 'page-' ~ uuid,
+        referrer: app.request.uri,
+        threadTitle: 'This is my title',
+        _format: 'html'
+    })) }}
+
+{% endblock %}

Tests/Functional/Controller/WebsiteCommentControllerTest.php

@@ -31,6 +31,7 @@ protected function setUp(): void
     {
         $this->client = $this->createAuthenticatedWebsiteClient();
         $this->purgeDatabase();
+        $this->initPhpcr();
     }
 
     public function providePostData()
@@ -292,6 +293,20 @@ public function testGetComments($type = 'blog', $entityId = '1')
         $this->assertEquals('Sulu is awesome', $response[1]['message']);
     }
 
+    public function testGetCommentsHtmlThreadTitle()
+    {
+        $crawler = $this->client->request(
+            'GET',
+            '/'
+        );
+
+        $input = $crawler->filter('input[type="hidden"]');
+
+        $this->assertSame('threadTitle', $input->attr('id'));
+        $this->assertSame('hidden', $input->attr('type'));
+        $this->assertSame('This is my title', $input->attr('value'));
+    }
+
     private function postComment(
         $type = 'blog',
         $entityId = '1',

Twig/CommentFormFactoryTwigExtension.php

@@ -42,8 +42,12 @@ public function getFunctions()
         ];
     }
 
-    public function createCommentForm(string $threadId, ?string $referrer = null, ?int $parent = null): FormView
-    {
+    public function createCommentForm(
+        string $threadId,
+        ?string $referrer = null,
+        ?int $parent = null,
+        ?string $threadTitle = null
+    ): FormView {
         $form = $this->formFactory->create(
             CommentType::class,
             null,
@@ -52,6 +56,7 @@ public function createCommentForm(string $threadId, ?string $referrer = null, ?i
                 'threadId' => $threadId,
                 'referrer' => $referrer,
                 'parent' => $parent,
+                'threadTitle' => $threadTitle,
             ]
         );