-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dockerfile to get fonts from GDrive instead #505
Conversation
@sumpfork this is waiting on your review since I made a change to GitHub workflows. If I should take that out and just update the dockerfile LMK. |
FROM --platform=linux/arm64 pacodrokad/fonts:latest AS fonts-image | ||
FROM alpine AS fonts-download | ||
# get the fonts from Google Drive | ||
RUN wget "https://drive.usercontent.google.com/download?id=1_BmJ1afnSt1rR_YAWhUCFDch8Bat78ti&export=download&authuser=0" -O fonts.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a personal google drive? I really don't like depending on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand where you're coming from. The normal solution would be to add them to this repository but we've talked about that before.
I'm trying to make it easier to run the CLI tools: "use the docker image" usually works well for many other open-source projects I use daily, so I want to build the fonts into the image. Is there some other place we could link these to enable Docker to grab them when it's building?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've resolved the other items but would appreciate your thoughts here on how we can make the dockerfile easy to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just don't think we can distribute them legally, so we shouldn't try.
I was cleaning requiements stuff up #507 anyway so cleaned up the dockerfile in a similar manner to this PR over there. Also added an example as to how to map the local dir into the container so you can use local fonts and actually get the pdf back out easily.
Yeah, let's take that out and try it in a separate PR. |
This was handled in #507 |
This improves the
dockerfile
that was trying to be too clever about fonts. Instead it just downloads them from a zip file on Google Drive.The features below were moved to another PR: