Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dockerfile to get fonts from GDrive instead #505

Closed
wants to merge 6 commits into from
Closed

update dockerfile to get fonts from GDrive instead #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da02111
update dockerfile to get fonts from GDrive instead
nickv2002 Feb 26, 2024
fff0676
add some comments/layer-optimization to dockerfile
nickv2002 Feb 26, 2024
dab3196
Create publish-docker.yml
nickv2002 Feb 26, 2024
1b42b82
Simplify Dockerfile, don't use dev setup commands
nickv2002 Mar 13, 2024
7f05d83
remove github workflows for anothter PR
nickv2002 Mar 13, 2024
9a500cd
improve ordering of commands in dockerfile
nickv2002 Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
.dockerignore
.dockerfile
dockerfile
README.md
requirements.txt
.github
tools
*pdf
37 changes: 20 additions & 17 deletions dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,32 @@
FROM --platform=linux/arm64 pacodrokad/fonts:latest AS fonts-image
FROM alpine AS fonts-download
# get the fonts from Google Drive
RUN wget "https://drive.usercontent.google.com/download?id=1_BmJ1afnSt1rR_YAWhUCFDch8Bat78ti&export=download&authuser=0" -O fonts.zip
RUN unzip -d /fonts -j fonts.zip
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a personal google drive? I really don't like depending on that.

Copy link
Collaborator Author

@nickv2002 nickv2002 Mar 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand where you're coming from. The normal solution would be to add them to this repository but we've talked about that before.

I'm trying to make it easier to run the CLI tools: "use the docker image" usually works well for many other open-source projects I use daily, so I want to build the fonts into the image. Is there some other place we could link these to enable Docker to grab them when it's building?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've resolved the other items but would appreciate your thoughts here on how we can make the dockerfile easy to use.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just don't think we can distribute them legally, so we shouldn't try.

I was cleaning requiements stuff up #507 anyway so cleaned up the dockerfile in a similar manner to this PR over there. Also added an example as to how to map the local dir into the container so you can use local fonts and actually get the pdf back out easily.


# Switch to using python:3.9-slim as the base image for the application.
FROM python:3.9-slim AS compile-image

# get fonts from the specified platform image
COPY --from=fonts-image /fonts /fonts
# Copying fonts first as this is less likely to change than source code,
# optimizing use of Docker's cache when rebuilding images.
COPY --from=fonts-download /fonts /fonts

# Add git for hooks
RUN apt-get update && apt-get install -y --no-install-recommends python3-icu git
# Combine apt-get update, software installation, and cleanup into a single RUN to reduce layers.
# Additionally, we remove the cache files to keep the image size down.
RUN apt-get update && \
apt-get install -y --no-install-recommends git && \
apt-get clean && \
rm -rf /var/lib/apt/lists/*

# get pip tools for computing requirements, and compile them
RUN python -m pip install pip-tools

# Set the working directory in the container (creating it in the process)
WORKDIR /app

# compile our requirements and then install them
COPY requirements.in .
RUN pip-compile --no-emit-index-url requirements.in && \
pip install -r requirements.txt

# Copy the local directory contents into the container at /app
# Copy the rest of application code.
COPY . .

# install the application
RUN python setup.py develop
# Compile and install dependencies
# then install the local package
RUN pip install -r requirements.txt \
&& pip install . \
&& rm -rf ~/.cache/pip

ENTRYPOINT ["/usr/local/bin/dominion_dividers"]
CMD ["--help"]
Loading