Accept either arrays or maps as input where appropriate #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
force-pushed
the
array-or-map
branch
2 times, most recently
from
500addb
to
79dfbdf
Compare
nabobalis
approved these changes
Aug 9, 2023
|
Thanks again @dstansby |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a decorator that can be used to mark a function argument as accepting either array or map input. There's also a flag that can convert the output of the function to a map.
To test I've modified an existing test fixture so at least one test gets run with
ndarrayandGenericMapinput for each of the modified functions.I think I've covered all the functions where this is appropriate, but a reviewer double checking this would be good!
Fixes #69.