Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
sinon just published its new version 1.17.5.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of sinon.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 29 commits .
d24a1f1
1.17.5
721801c
1.17.5: Update AUTHORS and Changelog
05363cf
Merge pull request #1110 from fatso83/release-improvement
7446d42
Only run on Node >= 0.12 in Travis
3640b99
Add prepublish steps to avoid including extra files
fc2f909
PR #1109: Simplify some logic in from #1108
19e49f6
Merge pull request #1108 from fearphage/v1.17-progress-event-compliance
24691cb
Merge pull request #1102 from fearphage/v1.17-dont-treat-non-200s-as-errors
95aa362
use xhr.progress (length of body/response) for progress event
06cc2ef
capture response length from setResponseBody
bf709a7
updated current tests to account for api changes
54aa22f
reverted tests
35129e0
added xhr.error() method to simulate network errors
3eb782d
stopped treating non-200 responses as errors
33ea740
copied XHR tests from master
There are 29 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade