-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDESK-7441] Create basic async resource models and services for planning.events
#2131
Conversation
SDESK-7441
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eos87 I've had a quick look over it, looks fine so far. Will re-review once you've completed the schema changes etc
Fix behave tests partially SDESK-7441 Allow behave tests to run async code SDESK-7441 Fix pytests and use python 3.10 only Disable some actions and add verbose mode 999 Remove python 3.8 Point sd core to fix branch Revert "Fix linter issues" This reverts commit 152cfb5. Revert changes to ci-install SDESK-7441 Fix first batch of tests Reapply "Fix linter issues" This reverts commit e5ac69a. Fix second batch of tests SDESK-7441 Fix tests batch 3 Fix tests batch 4 SDESK-7441 Fix superdesk-core dependency Fix linter issues SDESK-7441
SDESK-7441
SDESK-7441
SDESK-7441
Hey @MarkLark86, I've made the changes and left a couple of comments in the "unresolved" conversations. I added this small helper method superdesk-planning/server/planning/types/common.py Lines 202 to 207 in b85a4e2
superdesk-planning/server/planning/types/planning.py Lines 103 to 106 in b85a4e2
|
Not sure there would be many other places where this would be used, as it's mostly covered by the new type system. This use case is an edge case, all others I can think of are for the storage and search of the data itself, so should be fine to leave where it is |
Hey @eos87 just a few more changes to some fields from mandatory to optional: For
For
|
SDESK-7441
@BrianMwangi21 fixed Regarding |
Thanks. I'll see what to do about the names. |
SDESK-7441
SDESK-7441
Purpose
Implement the basic async resource and service for Planning Events app
What has changed
~82%
of them now green)v3.10
and latest actionsNote
This PR depends on superdesk/superdesk-core#2758.
Once that PR is merged, I will update the requirements here to point to superdesk-coreasync
branch instead.Thanks for checking!