Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The current version of apriltags-cpp has UNIX only functions and variables. By upgrading to a newer C++ and OpenCV version it's now possible to compile the library on Windows.
Changes
A quick overview of the changes made:
M_PI
toCV_PI
.gettimeofday
to cross platformstd::chrono
.Reasoning for pull request
When I initially found this library and wanted to play around with it, I immediately stumbled on the fact that this library isn't compatible with Windows. Because of my lack of experience with CMake back then, porting it seemed too far out of my reach. Having become more familiar with the Library, it seems like a good idea to make this library more accessible.
Caveats
getopt
function, I excluded the examples from compiling. However the library is compiled and adding an example PDF file should help people get something working.Possible improvements