Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDCISA-13736, SDCISA-10974] Refine logging in BufferBridge, LocalHttpClientRequest, LocalHttpConnection and RequestLogger #544

Merged
merged 1 commit into from
Jan 9, 2024

[SDCISA-13736, SDCISA-10974] Fix bad habits in BufferBridge, LocalHtt…

cfa2ffb
Select commit
Loading
Failed to load commit list.
Merged

[SDCISA-13736, SDCISA-10974] Refine logging in BufferBridge, LocalHttpClientRequest, LocalHttpConnection and RequestLogger #544

[SDCISA-13736, SDCISA-10974] Fix bad habits in BufferBridge, LocalHtt…
cfa2ffb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 5, 2024 in 1s

47.62% (-0.03%) compared to 0817082

View this Pull Request on Codecov

47.62% (-0.03%) compared to 0817082

Details

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (0817082) 47.65% compared to head (cfa2ffb) 47.62%.

Files Patch % Lines
...org/swisspush/gateleen/core/http/BufferBridge.java 0.00% 3 Missing ⚠️
...sspush/gateleen/core/http/LocalHttpConnection.java 0.00% 3 Missing ⚠️
...ush/gateleen/core/http/LocalHttpClientRequest.java 0.00% 2 Missing ⚠️
...swisspush/gateleen/core/logging/RequestLogger.java 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop     #544      +/-   ##
=============================================
- Coverage      47.65%   47.62%   -0.03%     
  Complexity      1785     1785              
=============================================
  Files            225      225              
  Lines          11727    11734       +7     
  Branches        1226     1226              
=============================================
  Hits            5588     5588              
- Misses          5651     5658       +7     
  Partials         488      488

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov