Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cluster-scanner): corrected role to support OKD4 #1247

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix(cluster-scanner): corrected role to support OKD4 #1247

merged 1 commit into from
Jul 20, 2023

Conversation

michele-mangili
Copy link
Collaborator

What this PR does / why we need it:

As per the title.

See the associated bug report.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@michele-mangili michele-mangili force-pushed the fix/cluster-scanner-okd-support branch from a0645f7 to b1499b3 Compare July 20, 2023 15:10
@michele-mangili michele-mangili marked this pull request as ready for review July 20, 2023 15:22
@michele-mangili michele-mangili requested a review from a team as a code owner July 20, 2023 15:22
@michele-mangili michele-mangili self-assigned this Jul 20, 2023
ProvoK
ProvoK approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@ProvoK ProvoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for this @michele-mangili !

@michele-mangili
Copy link
Collaborator Author

thanks a lot for this @michele-mangili !

My pleasure @ProvoK ;)

@michele-mangili michele-mangili merged commit cd8ebe9 into master Jul 20, 2023
5 checks passed
@michele-mangili michele-mangili deleted the fix/cluster-scanner-okd-support branch July 20, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProvoK ProvoK ProvoK approved these changes

Assignees

@michele-mangili michele-mangili

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michele-mangili @ProvoK