Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node-analyzer): In-USE (EVE) enabled by default #1501

Merged
merged 6 commits into from
Dec 13, 2023
Merged

feat(node-analyzer): In-USE (EVE) enabled by default #1501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7426802
feat(node-analyzer): In-USE (EVE) enabled by default
airadier Nov 29, 2023
bb7af15
Merge branch 'master' into enable-in-use-by-default
airadier Dec 12, 2023
099b705
Merge branch 'master' into enable-in-use-by-default
airadier Dec 12, 2023
589b877
Bumping minor version
airadier Dec 12, 2023
5c01b96
Bump sysdig-deploy version
airadier Dec 12, 2023
c4c9c57
Merge branch 'master' into enable-in-use-by-default
airadier Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions charts/node-analyzer/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
apiVersion: v2
name: node-analyzer
description: Sysdig Node Analyzer

# currently matching Sysdig's appVersion 1.14.34
version: 1.19.2
version: 1.20.0
appVersion: 12.9.0
keywords:
- monitoring
Expand Down
2 changes: 1 addition & 1 deletion charts/node-analyzer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ The following table lists the configurable parameters of the Sysdig Node Analyze
| `nodeAnalyzer.runtimeScanner.resources.limits.ephemeral-storage` | Specifies the Runtime Scanner Storage limit per node. | `4Gi` |
| `nodeAnalyzer.runtimeScanner.sslVerifyCertificate` | Set to `false` to allow insecure connections to the Sysdig backend, such as an On-Prem deployment. | |
| `nodeAnalyzer.runtimeScanner.env` | Specifies the extra environment variables that will be passed onto pods. | `{}` |
| `nodeAnalyzer.runtimeScanner.settings.eveEnabled` | Enables Sysdig Eve | `false` |
| `nodeAnalyzer.runtimeScanner.settings.eveEnabled` | Enables Sysdig Eve | `true` |
| `nodeAnalyzer.runtimeScanner.eveConnector.image.repository` | Specifies the image repository to pull the Eve Connector from. | `sysdig/eveclient-api` |
| `nodeAnalyzer.runtimeScanner.eveConnector.image.tag` | Specifies the image tag for the Eve Connector to be pulled. | `1.1.0` |
| `nodeAnalyzer.runtimeScanner.eveConnector.deploy` | Enables Sysdig Eve Connector for third-party integrations. | `false` |
Expand Down
2 changes: 0 additions & 2 deletions charts/node-analyzer/templates/daemonset-node-analyzer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,8 +719,6 @@ spec:
name: {{ .Release.Name }}-runtime-scanner
key: eve_enabled
optional: true
{{- end }}
{{- if .Values.nodeAnalyzer.runtimeScanner.eveConnector.deploy }}
- name: EVE_INTEGRATION_ENABLED
valueFrom:
configMapKeyRef:
Expand Down
2 changes: 0 additions & 2 deletions charts/node-analyzer/templates/runtimeScanner/runtime-scanner-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ data:
{{- end -}}
{{- if .Values.nodeAnalyzer.runtimeScanner.settings.eveEnabled }}
eve_enabled: "true"
{{- end -}}
{{- if hasKey .Values.nodeAnalyzer.runtimeScanner "eveConnector" }}
eve_integration_enabled: "true"
{{- end -}}
{{- if hasKey .Values.nodeAnalyzer.runtimeScanner "settings" }}
Expand Down
4 changes: 2 additions & 2 deletions charts/node-analyzer/tests/conditional_flag_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ tests:
count: 1
any: true

- it: Check nodeAnalyzer runtimeScanner eveConnector deploy set to false
- it: Check nodeAnalyzer runtimeScanner EVE_INTEGRATION_ENABLED is true even if eveConnector deploy set to false
set:
nodeAnalyzer:
runtimeScanner:
Expand All @@ -204,7 +204,7 @@ tests:
deploy: false
clusterName: test-k8s
asserts:
- notContains:
- contains:
path: spec.template.spec.containers[3].env
content:
name: EVE_INTEGRATION_ENABLED
Expand Down
2 changes: 1 addition & 1 deletion charts/node-analyzer/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ nodeAnalyzer:
env: {}

settings:
eveEnabled: false
eveEnabled: true
# Threshold for which images will be skipped in the analysis.
# Size is in bytes, default is not set (don't skip)
# maxImageSizeAllowed: ""
Expand Down
4 changes: 2 additions & 2 deletions charts/sysdig-deploy/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: sysdig-deploy
description: A chart with various Sysdig components for Kubernetes
type: application
version: 1.33.3
version: 1.34.0
maintainers:
- name: AlbertoBarba
email: [email protected]
Expand Down Expand Up @@ -36,7 +36,7 @@ dependencies:
- name: node-analyzer
# repository: https://charts.sysdig.com
repository: file://../node-analyzer
version: ~1.19.2
version: ~1.20.0
alias: nodeAnalyzer
condition: nodeAnalyzer.enabled
- name: cluster-scanner
Expand Down
Loading