Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-analyzer): In-USE (EVE) enabled by default #1501

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

airadier
Copy link
Collaborator

@airadier airadier commented Nov 29, 2023

What this PR does / why we need it:

In-Use (EVE) will now be GA and officially enabled by default for all customers.

With this PR we change the eveEnabled setting to true by default, and we fix an issue where EVE integrations where only enabled if eveConnector component was also deployed. This is not necessary, as some integrations happen via a public API, but we need to make sure that EVE_INTEGRATION_ENABLED environment variable is also set to true, or the public API won't have any data.

Setting the PR as draft until dependent components are GA.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@airadier airadier marked this pull request as ready for review December 12, 2023 18:15
@airadier airadier requested a review from a team as a code owner December 12, 2023 18:25
@airadier airadier merged commit c43ad62 into master Dec 13, 2023
5 checks passed
@airadier airadier deleted the enable-in-use-by-default branch December 13, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants