Fix COMMIT|ROLLBACK forwarding to backend connections - Closes #4264
#4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These commands are now forwarded to the backend connections from a
session with potential transaction statuses, using the following
priority order:
1. Connections flagged with 'SERVER_STATUS_IN_TRANS', or
'autocommit=0' when 'autocommit_false_is_transaction' is set.
2. Connections with 'autocommit=0' holding a 'SAVEPOINT'.
3. Connections with 'unknown transaction status', e.g: connections
with errors.
- General testing for 'COMMIT|ROLLBACK' routing. - Add multiple testing utility functions.
5 tasks
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the routing of
COMMIT|ROLLBACKto backend connections, imposing a priority for it based on the connections potential transaction statuses:SERVER_STATUS_IN_TRANS, orautocommit=0whenautocommit_false_is_transactionis set.autocommit=0holding aSAVEPOINT.unknown transaction status, e.g: connections with errors.