Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix COMMIT|ROLLBACK forwarding to backend connections - Closes #4264 #4306

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Fix COMMIT|ROLLBACK forwarding to backend connections - Closes #4264 #4306

merged 5 commits into from
Jul 31, 2023

Commits on Jul 28, 2023

  1. Fix 'COMMIT|ROLLBACK' forwarding to backend connections - Closes #4264 

    These commands are now forwarded to the backend connections from a
session with potential transaction statuses, using the following
priority order:
  1. Connections flagged with 'SERVER_STATUS_IN_TRANS', or
     'autocommit=0' when 'autocommit_false_is_transaction' is set.
  2. Connections with 'autocommit=0' holding a 'SAVEPOINT'.
  3. Connections with 'unknown transaction status', e.g: connections
     with errors.
    @JavierJF
    JavierJF committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    bb40e9e View commit details
    Browse the repository at this point in the history

  2. Add regression test for issue #4264 

    - General testing for 'COMMIT|ROLLBACK' routing.
- Add multiple testing utility functions.
    @JavierJF
    JavierJF committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    f35cebf View commit details
    Browse the repository at this point in the history

  3. Remove duplicate code from several tests

    @JavierJF
    JavierJF committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3843a54 View commit details
    Browse the repository at this point in the history

  4. Remove old commented code for 'IsActiveTransaction' impl

    @JavierJF
    JavierJF committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    0d8860e View commit details
    Browse the repository at this point in the history

  5. Add missing 'plan' to regression test for #4264

    @JavierJF
    JavierJF committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d36605e View commit details
    Browse the repository at this point in the history