feat(TA-1696): set cors allow credentials optionally #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikerudd
commented
Oct 7, 2024
| @@ -99,6 +99,15 @@ describe("AuthenticatedApi", () => { | |||
| { | |||
| Name: "test-MyTestAuthenticatedApi", | |||
| ProtocolType: "HTTP", | |||
| CorsConfiguration: { | |||
| AllowCredentials: true, | |||
There was a problem hiding this comment.
comment: confirms that by default AllowCredentials is set to true to ensure backwards compatibility.
junglebarry
approved these changes
Oct 8, 2024
malcyL
approved these changes
Oct 8, 2024
haakym
approved these changes
Oct 8, 2024
mikerudd
deleted the
ta-1696_authenticated_api_cors_optionally_allow_credentials
branch
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
talis-cdk-constructs hard codes the value of the CORS header
access-control-allow-credentialstotrue. We have a requirement in the new extension to wildcardaccess-allow-originshowever, whenaccess-control-allow-credentialsvalue is true, AWS API Gateway will not allow you to wildcard the origins. We therefore need to be able to setaccess-control-allow-credentialsto false so that we can wildcard the origin.