Allow editor switch entities #3236 #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run CI in merge queue
…_space_in_systemc Remove trailing space in system.c teeworlds#3220
…unused Mark unused NETMSG_SNAPSMALL for 0.8 removal teeworlds#3210
When a new player joins it is being sent all the client info of the currently connected tees. This is marked as non silent which is misleading because the client does not actually print these as join messages. The reason why the client does not print it is because it does not have its m_LocalClientID set yet. Setting it explicitly to silent makes it more obvious that this is not printing a chat message when reading the server code. This change will not change anything that can be witnessed by end users. This also ensures that when the client implementation changes it does not start printing unexpected "joined the game" messages in chat.
https://github.com/teeworlds/teeworlds/blob/a1911c8f7d8458fb4076ef8e7651e8ef5e91ab3e/datasrc/network.py#L253 NetEvent("Damage:Common", [ # Unused yet NetIntRange("m_ClientID", 0, 'MAX_CLIENTS-1'), NetIntAny("m_Angle"), NetIntRange("m_HealthAmount", 0, 9), NetIntRange("m_ArmorAmount", 0, 9), NetBool("m_Self"), ]), Snap items with a m_ClientID out of range will be dropped during snap item validation.
…_client_info Silence initial client info teeworlds#3218
…_code Remove unreachable dmg indicator code teeworlds#3217
Replace skinpart magic number with enum teeworlds#3213
Refresh ServerBrowser using F5 teeworlds#3188
Remove useless assignment to variable teeworlds#3208
…filenames Port str_comp_filenames from ddnet to fix buffer overflow teeworlds#3219
Update copyright year to 2024 teeworlds#3215
…mp0148 Fix CMP0148 teeworlds#3212
Fixed cursor offset in the editor and removed brush display when picking tiles teeworlds#3222
Try fix macOS CI failure teeworlds#3223
Fix doc typos
Add CJsonParser, revise io_read_all/io_read_all_str teeworlds#3141
Polyfill distutils.copy_tree because it was removed teeworlds#3229
It's overflowing easily, especially considering colorcodes.
fixes
$ python ./scripts/cmd5.py
/Users/chillerdragon/Desktop/git/teeworlds/./scripts/cmd5.py:11: SyntaxWarning: invalid escape sequence '\/'
d = re.sub("\/\*.*?\*/".encode(), "".encode(), d) # remove /* */ comments
#define GAME_NETVERSION_HASH "e9800998ecf8427e"
…kkonaut_patch-2 Increase broadcast size teeworlds#3242
…llerDragon_pr_cmd5_fix_esc_seq_warning Fix cmd5.py SyntaxWarning: invalid escape sequence teeworlds#3225
ci: use `fail-fast: false`
tempral
previously approved these changes
Apr 9, 2024
ChillerDragon
dismissed
tempral’s stale review
The merge-base changed after approval.
ChillerDragon
force-pushed
the
community
branch
from
66a1989 to
c56fa9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream: https://www.github.com/teeworlds/teeworlds/pull/3236