Refactor the TF Provider to use the experimental Go SDK CloudOpsAPIClient Issue #120 #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This is a significant change that touched most files in the TF Provider.
Most changes occurred in the client.go file.
Why?
To reduce technical debt and improve the speed at which new protos are exposed through the TF provider, we want to use the Go SDK to access all cloud ops apis as opposed to compiling raw protos and including directly into the TF provider.
Checklist
Closes [Feature Request] Update the TF Provider to use the embedded protos in the Temporal Go SDK >= 1.26.0 experimental release #120
How was this tested:
this change was tested in 2 ways:
-- note | it didn't appear that the resource tests were executed using go test ./... . Because of this, individual tests were invoked using
go test -v -run
commands and referencing specific teststerraform apply
for each resource and data source included in the TF provider-- manual tests followed the test instructions included in this repo's README
-- manual test .tf files are available
possibly, i added a Go SDK requirement to the Requirements section of README but did not make any other changes