Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scripts] Update default minio tag to RELEASE.2024-08-29T01-40-52Z #3744

Merged
merged 5 commits into from
Sep 18, 2024
Merged

[scripts] Update default minio tag to RELEASE.2024-08-29T01-40-52Z #3744

merged 5 commits into from
Sep 18, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Sep 9, 2024 •
edited
Loading

This PR makes the following changes:

  • Changes the default minio tag in scripts from RELEASE.2022-09-22T18-57-27Z to RELEASE.2024-08-29T01-40-52Z
  • Fixes bug in S3store where verifying the client will fail in newer versions of minio
  • Bumps @terascope/scripts from v1.1.0 to v1.1.1

Ref to issue #3742

@sotojn sotojn self-assigned this Sep 9, 2024
@sotojn
Copy link
Contributor Author

sotojn commented Sep 9, 2024

I have verified that minio RELEASE.2024-08-29T01-40-52Z works with file-asset tests on master branch. This was done by running MINIO_VERSION="RELEASE.2024-08-29T01-40-52Z" yarn test:all at the top level of file assets.

@sotojn sotojn changed the title Update default minio tag to RELEASE.2024-08-29T01-40-52Z [scripts]Update default minio tag to RELEASE.2024-08-29T01-40-52Z Sep 10, 2024
@sotojn sotojn changed the title [scripts]Update default minio tag to RELEASE.2024-08-29T01-40-52Z [scripts] Update default minio tag to RELEASE.2024-08-29T01-40-52Z Sep 10, 2024
@sotojn sotojn marked this pull request as ready for review September 10, 2024 22:10
@sotojn sotojn requested review from busma13 and godber September 11, 2024 15:45
busma13
busma13 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@godber godber merged commit cda833b into master Sep 18, 2024
67 checks passed
@godber godber deleted the update-minio-RELEASE.2024-08-29T01-40-52Z branch September 18, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busma13 busma13 busma13 approved these changes

@godber godber godber approved these changes

Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sotojn @godber @busma13