Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: trailing whitespace fixes #33

Merged
merged 14 commits into from
Dec 16, 2022
Merged

fmt: trailing whitespace fixes #33

merged 14 commits into from
Dec 16, 2022

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Dec 13, 2022

No description provided.

@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 13, 2022

@alixander

./ci/render.sh text

Screenshot 2022-12-13 at 1 16 05 AM

./ci/render.sh /mmdc

Screenshot 2022-12-13 at 1 16 44 AM

./ci/render.sh text/d2

Screenshot 2022-12-13 at 1 17 25 AM

@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 13, 2022

This also adds ./src/examples/10_wiiu/render/mermaid_dagre.svg as the latest version of mermaid is able to compile fine.

before we were showing the error:

Compile error: On the latest version of Mermaid CLI, the text returns a mysterious "Error: Evaluation failed: Error: Unknown mermaid render error". On mermaid.live, the same text renders fine.

@nhooyr nhooyr force-pushed the whitespace-2eec branch 2 times, most recently from 0d69d89 to 5c042f9 Compare December 13, 2022 09:33
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 13, 2022

Also see #34, won't run render.sh in CI for now.

@nhooyr nhooyr disabled auto-merge December 16, 2022 07:54
@nhooyr nhooyr merged commit d5277a8 into master Dec 16, 2022
@nhooyr nhooyr deleted the whitespace-2eec branch December 16, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants