Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mech skill #16941

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mech skill #16941

wants to merge 2 commits into from

Conversation

TiviPlus
Copy link
Member

@TiviPlus TiviPlus commented Jan 18, 2025 •
edited by github-actions bot
Loading

About The Pull Request

Splits large vehicles into mech and large vehicles

Why It's Good For The Game

No more acs with mechs for good

Changelog

🆑
fix: ACs can no longer use any mech related objects as intended
/:cl:

@TiviPlus TiviPlus added the Fix Fixes an issue with the game. label Jan 18, 2025
Lumipharon
Lumipharon requested changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@Lumipharon Lumipharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you havent changed any of the skill procs/helpers

@Looking4bros
Copy link
Contributor

How would we test in valhalla as well? Mech pilot was the way to get that.

@TiviPlus
Copy link
Member Author

you havent changed any of the skill procs/helpers

where exactly

@TiviPlus
Copy link
Member Author

How would we test in valhalla as well? Mech pilot was the way to get that.

fallen mp

@Lumipharon
Copy link
Contributor

you havent changed any of the skill procs/helpers

where exactly

/datum/skills/proc/modifyRating etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lumipharon Lumipharon Lumipharon requested changes

Assignees
No one assigned
Labels
Fix Fixes an issue with the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TiviPlus @Looking4bros @Lumipharon