Fixed: Correctly show heading in tabular template #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drikusroor
changed the title
Closed
|
Thanks! |
drikusroor
added a commit
to Amsterdam-Music-Lab/MUSCLE
that referenced
this pull request
Aug 30, 2024
drikusroor
added a commit
to Amsterdam-Music-Lab/MUSCLE
that referenced
this pull request
Sep 4, 2024
…ck` (#1227) * feat: Add BlockTranslatedContent model and relate it to Block with a ManyToMany relationship * refactor: Migrate block content and associated models * refactor: Add `translated_content` as `ManyToMany` field of `Block` instead of on `BlockTranslatedContent` * feat: Warn user about missing translated contents * refactor: Remove hashtag, url, consent & language from block * refactor: Move warnings to remarks column * fix: Fix many tests after removing consent/url/hashtags from block model * doc: Update consent's doc string * fix: Fix minor test * fix: Fix remainder of tests * fix: Validating the model before saving the model and its relations results into errors as the validator looks for translated content using the FKs * refactor: Handle missing language in content * fix: Re-add Hooked ID * refactor(`BlockTranslatedContent`) Refactor `Block`-`BlockTranslatedContent` relationship to `ForeignKey` - Update Block model to use ForeignKey for translated_contents - Modify migrations to reflect new relationship - Adjust admin interface to handle inline editing of translated contents - Update related queries and methods to use new relationship structure * refactor: Use tabular inline for block translated content * fix: Fix border radius top left in markdown input * feat: Add all necessary fields for experiment translated content to its form * chore: Remove unnecessary print statement * fix: Add `BlockTranslatedContentInline` inline to `BlockAdmin` * fix: Create temporary fix for tabular inline headings appearing out of its h2 element See also: - theatlantic/django-nested-admin#261 - theatlantic/django-nested-admin#259 * chore: Incorporate latest version of `django-nested-admin` that includes fix for the tabular inline form's heading * refactor: Rename test to be more descriptive * refactor: Incorporate the migration of #1240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261
There seems to be a small markup error in the tabular template: The
h2heading element is closed twice, causing the heading content to be shown outside of the heading element, looking likespan-ish text with regards to styling. See also the screenshots below:Current situation
Situation after fix
This PR then removes the first
h2closing tag so that the title will have the correct position and styling.