Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippy gene query product names are truncated if they contain commas #99

Closed
michellescribner opened this issue Jun 16, 2023 · 0 comments · Fixed by #102
Closed

Snippy gene query product names are truncated if they contain commas #99

michellescribner opened this issue Jun 16, 2023 · 0 comments · Fixed by #102
Labels
done This issue has been addressed

Comments

@michellescribner
Copy link
Contributor

michellescribner commented Jun 16, 2023

The snippy gene query task has the following steps:

  1. queries the variant calling output for query strings
  2. saves the rows with those strings to a csv
  3. parses the csv to save the product name and mutation to a variable

If the product name contains a comma, it interferes with step 3 and causes the product name to be truncated.

Example:

For the mutation below, the product should be shown as "1,3-beta-glucan synthase component FKS1" in the theiaeuk_snippy_variant_hits output, but is instead truncated to just "1".

CHROM POS TYPE REF ALT EVIDENCE FTYPE STRAND NT_POS AA_POS EFFECT LOCUS_TAG GENE PRODUCT
PEKT02000002 1006622 snp A C C:53 A:0 CDS - 1918/5667 640/1888 missense_variant c.1918T>G p.Leu640Val B9J08_000964 - 1,3-beta-glucan synthase component FKS1
@sage-wright sage-wright linked a pull request Jun 21, 2023 that will close this issue
4 tasks
@sage-wright sage-wright added the done This issue has been addressed label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done This issue has been addressed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants