Snippy Gene Query fixes #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested TheiaEuk snippy gene query bug fix here: https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Scribner_Sandbox/job_history/f6ad89bf-0648-413a-8125-596ff4006778 |
michellescribner
previously approved these changes
Jul 5, 2023
|
omg I'm going crazy I keep getting confused on what branch I'm on. FYI, I do not recommend trying to fix the CI for two separate branches at the same time haha |
|
@michellescribner -- tests are now passing! 🎉 |
kevinlibuit
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99
🛠️ Changes Being Made
~{validation_criteria_tsv}variable in quotes in TheiaValidate🧠 Context and Rationale
The snippy_gene_query change prevents incomplete results; the variable quoting prevents workflow failure.
📋 Workflow/Task Steps
No change
Inputs
No change
Outputs
No change
🧪 Testing
Locally
Tests were successful.
Terra
Testing for snippy_gene_query ongoing here:
Test for the TheiaValidate bug fix can be found here: https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Wright_PHBG_Sandbox/job_history/83e229c0-7dd2-4000-96c3-2ba9caa04877
🔬 Quality checks
Pull Request (PR) checklist: