Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small shigella updates, take 2 #125

Merged
merged 3 commits into from
Jul 21, 2023
Merged

small shigella updates, take 2 #125

merged 3 commits into from
Jul 21, 2023

Conversation

kapsakcj
Copy link
Contributor

@kapsakcj kapsakcj commented Jul 21, 2023

Opened a new PR so I don't pollute the commit history with my old PR and failed attempt at rebasing.

Need to update CI and test once more in Terra, but should be ready for review shortly

🛠️ Changes Being Made

  • updated default shigatyper docker image to v2.0.5 (from 2.0.3) hosted on GAR
  • added optional Integer input memory for shigatyper task.
  • exposed optional String input shigatyper_docker_image in merlin_magic subwf so that user has the ability to change via TheiaProk workflows in Terra

🧠 Context and Rationale

Previously the user was not able to adjust the shigatyper docker image, meaning they were stuck with the previous version that had a bug with Shigella flexneri serotyping. The updated version 2.0.5 fixes this bug.

📋 Workflow/Task Steps

The usual TheiaProk workflow

Inputs

Outputs

🧪 Testing

Locally

only tested on Terra, these are minor changes

Terra

Successful workflow: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/83e40c1c-125c-4515-931b-5f5496a731d6 with data table called linlin_shigella_core_sample

🔬 Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The workflow/task has been tested locally and on Terra
  • The CI/CD has been adjusted and tests are passing
  • Everything follows the style guide

@kapsakcj kapsakcj marked this pull request as ready for review July 21, 2023 14:24
@sage-wright sage-wright merged commit 875cf55 into main Jul 21, 2023
8 checks passed
@kapsakcj kapsakcj deleted the cjk-shigella-updates2 branch July 21, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants