Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default docker for busco to GAR docker image #132

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

kapsakcj
Copy link
Contributor

@kapsakcj kapsakcj commented Jul 27, 2023

🛠️ Changes Being Made

This PR updates the default docker image for BUSCO to us-docker.pkg.dev/general-theiagen/ezlabgva/busco:v5.3.2_cv1. Must have missed that when we switched to all the GAR-hosted images.

I've double checked that the GAR docker image repo is public, as allUsers can read the artifact registry repo

This also exposes optional Int inputs cpu and memory in case it's ever necessary for the user

🧠 Context and Rationale

So that we are not relying upon an docker image & repo that we do not maintain or have control over.

📋 Workflow/Task Steps

NA

Inputs

NA

Outputs

NA

🧪 Testing

Locally

Did not test locally, this is a simple PR

Terra

Tested with TheiaProk_Illumina_PE_PHB here, I expect it to run successfully it ran successfully: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/6427308f-7659-48d6-97db-932431df1610

🔬 Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The workflow/task has been tested locally and on Terra
  • The CI/CD has been adjusted and tests are passing
  • Everything follows the style guide

@kapsakcj
Copy link
Contributor Author

I pushed a commit to update the CI, but it's not showing up on the PR here... 🤔

4741c48

waiting to mark ready for review until it's resolved

@kapsakcj
Copy link
Contributor Author

OK so I'm not crazy 😀

image

@kapsakcj kapsakcj marked this pull request as ready for review July 28, 2023 16:30
Copy link
Member

@sage-wright sage-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic work

@sage-wright sage-wright merged commit 7cc91fb into main Jul 28, 2023
7 checks passed
@kapsakcj kapsakcj deleted the cjk-busco-docker-default branch July 28, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants