-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Workflow] Adding the TheiaMeta_Panel_Illumina_PE Workflow #656
Open
sage-wright
wants to merge
50
commits into
main
Choose a base branch
from
smw-theiameta-panel-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #553
🗑️ This dev branch should NOT be deleted after merging to main.
🧠 Summary
The Illumina VSP panel is one example of a panel-based sequencing assay. This particular panel contains over 200 target viruses,. This data cannot be analyzed using the traditional TheiaMeta analysis pathway due to the numerous target organisms which makes the assembly first-bin later approach undesirable. TheiaMeta_Panel performs taxonomic binning first with Kraken, then attempts to assemble those bins. If the organism to which the bin belongs is supported in TheiaCoV, we perform additional characterization steps, though the results of those characterizations are not always of high quality. The user must be cautious before reporting on the characterization results.
⚡ Impacted Workflows/Tasks
This PR may lead to different results in pre-existing outputs: No
This PR uses an element that could cause duplicate runs to have different results: No
🛠️ Changes
⚙️ Algorithm
TheiaMeta_Panel takes the following approach:
morgana_magic
which performs characterization depending on the organism.Assembly is fault resistant, meaning that if one shard fails, the workflow continues
This has impacts for TheiaMeta as workflows will no longer fail if assembly fails in either the metaspades or pilon tasks
➡️ Inputs
Many, please see documentation
⬅️ Outputs
Many, please see documentation
🧪 Testing
Tested regular TheiaMeta on 5 HAV samples here
Tested 21 Illumina VSP samples with TheiaMeta Panel here
Suggested Scenarios for Reviewer to Test
🔬 Final Developer Checklist
🎯 Reviewer Checklist