Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OT in a nutshell #775

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

OT in a nutshell #775

wants to merge 9 commits into from

Conversation

ArinaDanilina
Copy link
Collaborator

No description provided.

@ArinaDanilina ArinaDanilina requested a review from MUCDK January 4, 2025 11:21
@MUCDK
Copy link
Collaborator

MUCDK commented Jan 4, 2025

Thanks @ArinaDanilina , excellent first iteration.

A few points:

  1. The GW equation does not render for me, can you please double check?
  2. Can we include some image for the linear problem?
  3. Please make sure to cite where you got the graphics from!
  4. Unbalanced OT: tau_1/2 are commonly referred to as lambda_1/2, and tau = lambda/(lambda + eps). please check your BSc thesis again
  5. Let's have it linked below "Developer API" in the index

@MUCDK
Copy link
Collaborator

MUCDK commented Jan 8, 2025

great, thanks.

few more things:

  • at the end of each section link the bio/generic problems of that type, just along the lines of. and are linear problems.
  • for unbalanced OT use KL-div. instead of generic phi divergence
  • for unb. OT the tau is still wrong. it's lambda, and then say tau=lambda/(lamda+eps)

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (b55a0e4) to head (c805f9c).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   77.46%   77.53%   +0.06%     
==========================================
  Files          37       38       +1     
  Lines        4363     4376      +13     
  Branches      677      677              
==========================================
+ Hits         3380     3393      +13     
  Misses        657      657              
  Partials      326      326              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants