Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Fix kebechet adviser metrics, fix pre-commit, update pyproject.toml #557

Merged
merged 8 commits into from
Apr 6, 2022

Conversation

xtuchyna
Copy link
Member

@xtuchyna xtuchyna commented Apr 6, 2022

Related Issues and Dependencies

thoth-station/core#322

This introduces a breaking change

  • No

This should yield a new module release

  • Yes

This Pull Request implements

advisor manager metrics to be used as entity rather than plain json

@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 6, 2022
@xtuchyna
Copy link
Member Author

xtuchyna commented Apr 6, 2022

/approve

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@sesheta sesheta requested review from harshad16 and KPostOffice April 6, 2022 17:44
@sesheta sesheta added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2022
@xtuchyna xtuchyna changed the title Fix kebechet adviser metrics Fix kebechet adviser metrics, fix pre-commit Apr 6, 2022
@xtuchyna xtuchyna changed the title Fix kebechet adviser metrics, fix pre-commit Fix kebechet adviser metrics, fix pre-commit, update pyproject.toml Apr 6, 2022
@xtuchyna
Copy link
Member Author

xtuchyna commented Apr 6, 2022

/approve

@sesheta sesheta merged commit 5e38c8a into thoth-station:master Apr 6, 2022
@sesheta
Copy link
Member

sesheta commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xtuchyna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants