Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add merge cronjob #1500

Merged
merged 4 commits into from
Jun 4, 2021
Merged

Add merge cronjob #1500

merged 4 commits into from
Jun 4, 2021

Conversation

xtuchyna
Copy link
Member

Related Issues and Dependencies

Related to thoth-station/kebechet#546 (comment)

Does this require new deployment ?

  • Deployment for Test and Stage AICoE/aicoe-cd and Prod operate-first/argocd-apps.

Description

New merge cronjob, that aggregates all the data mi has collected about kebechet

@sesheta sesheta requested review from fridex and goern May 31, 2021 12:45
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 31, 2021
@xtuchyna xtuchyna mentioned this pull request May 31, 2021
Merged
2 tasks
@xtuchyna
Copy link
Member Author

/retest

@sesheta sesheta added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2021
goern
goern reviewed May 31, 2021
View reviewed changes
mi-scheduler/base/cronjob.yaml
value: 'thoth.mi-scheduler:INFO'
restartPolicy: OnFailure
---
kind: CronJob
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a cronjob or do we want it to be an ArgoCronjobWorkflow? @harshad16

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to join kebechet's merge and analyse into the one ArgoCronjobWorkflow? Or what's the use case here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was more a general question, CronJob is good ;)

@xtuchyna
Copy link
Member Author

xtuchyna commented Jun 2, 2021

hello @goern @harshad16 ! 🚁
any news regarding this?

@xtuchyna
Copy link
Member Author

xtuchyna commented Jun 4, 2021

aloha @goern @harshad16 any status on this?
@pacospace wdyt?

@goern
Copy link
Member

goern commented Jun 4, 2021

/approve

@sesheta
Copy link
Member

sesheta commented Jun 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2021
@sesheta sesheta merged commit c512358 into thoth-station:master Jun 4, 2021
@xtuchyna xtuchyna mentioned this pull request Jun 8, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goern goern goern left review comments

@fridex fridex Awaiting requested review from fridex

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtuchyna @goern @sesheta