Update Thanksgiving Day app to dynamically calculate days till thanksgiving #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current logic only works for 2024 and 2025. New logic works indefinitely.
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
![tidbyt[bot]](https://avatars.githubusercontent.com/u/57181397?s=60&v=4){kind=small}
|
I have read the CLA Document and I hereby sign the CLA |
Update > 0 day logic to >= 0
savdagod
changed the title
IngmarStein
reviewed
Nov 11, 2024
| print(thanksgiving) | ||
| days_til_thanksgiving = math.ceil(time.parse_duration(thanksgiving - now).seconds / 86400) | ||
| print(days_til_thanksgiving) | ||
| timezone = config.get("timezone") or "America/New_York" |
There was a problem hiding this comment.
Should this be timezone = config.get("$tz", "America/New_York")?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic is hard coded for 2024 and 2025. This update changes the logic to calculate the days indefinitely.