-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Thanksgiving Day app to dynamically calculate days till thanksgiving #2872
Open
savdagod
wants to merge
12
commits into
tidbyt:main
Choose a base branch
from
savdagod:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2960a7a
Fix math to dynamically update days
savdagod a4dc377
Delete apps/thanksgivingday/thanksgiving_day.star
savdagod 4dd209b
Update and rename thankgiving_day.star to thanksgiving_day.star
savdagod 1f2e311
Update thanksgiving_day.star
savdagod b0f8dae
Update thanksgiving_day.star
savdagod f21533e
Add files via upload
savdagod b3631e7
Delete apps/thanksgivingday/thanksgiving_day.star
savdagod 0228f93
Update and rename thankgivingday.star to thanksgiving_day.star
savdagod b90a693
Update thanksgiving_day.star
savdagod a5621f0
Fix lint
savdagod 23ed5f1
Update thanksgiving_day.star
savdagod 124df03
Update lint
savdagod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
timezone = config.get("$tz", "America/New_York")
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m gonna be honest, I have no idea. Looks to be that way ($tx) in some of the other countdown apps (ie Christmas) but it’s this way (timezone) in the Halloween countdown. Not sure which way is the correct way.