fix(android): fix global header/footer title in ListView #14160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I don't think it is widely used but you can add a
headerTitle
/footerTitle
in the ListView instead of the ListSection. When I was working on the test suite PR (#14158) I saw that that test was failing.12.6.1.GA:
The issue is that the
content
section has no view (as it is just the global headerTitle, so it doesn't have items) and that messes up the constraints. The "global header view" is visible as it creates a view.Fix
As I don't know at this point which kind of headerTitle (section or global) I just check if there are views inside the
content
section. If not I create an empty view and add it. That will keep the constraints workingTest