fix: make android mocha tests run again #14158
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why the Android mocha tests weren't running anymore. Turns out: the generated tiapp.xml was invalid. There was a missing
>
and it had two<application>
(we have a default one in the template now) nodes.Fixing some tests:
headerTitle/footerTitle is not working (even with 12.5.0) so disabling that for the moment- Fixed in fix(android): fix global header/footer title in ListView #14160Interesting point:
tableView.deleteRow(tableView.sections[0].rows[2]);
is not working in the emulator but on a device it is working fine 🤷 That's one test that is still failing but couldn't fix it yet.