Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(turn_signal, lane_change, goal_planner): add optional to tackle lane change turn signal and pull over turn signal #1468

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

Owen-Liuyuxuan
Copy link

Description

Cherry-pick the modification into beta branches.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…ane change turn signal and pull over turn signal (autowarefoundation#8463)

* add optional to tackle LC turn signal and pull over turn signal

Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>

* CPP file should not re-define default value; typo in copying from internal repos

Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>

---------

Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
@Owen-Liuyuxuan Owen-Liuyuxuan enabled auto-merge (squash) August 15, 2024 02:36
Copy link

sonarcloud bot commented Aug 15, 2024

Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Owen-Liuyuxuan Owen-Liuyuxuan merged commit 9969fe9 into beta/v0.29.0 Aug 16, 2024
21 of 22 checks passed
@Owen-Liuyuxuan Owen-Liuyuxuan deleted the hotfix/v0.29.0/traffic_light branch August 16, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants