Fix flaky Hypercore tests #7368
Merged
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7368 +/- ##
==========================================
+ Coverage 80.06% 82.57% +2.50%
==========================================
Files 190 229 +39
Lines 37181 42726 +5545
Branches 9450 10733 +1283
==========================================
+ Hits 29770 35279 +5509
- Misses 2997 3166 +169
+ Partials 4414 4281 -133 ☔ View full report in Codecov by Sentry. |
erimatnor
force-pushed
the
hypercore-fix-flaky-tests
branch
from
f0ef6db
to
0b9db39
Compare
mkindahl
approved these changes
Oct 20, 2024
Having multiple indexes that include same prefix of columns caused the planner to sometimes pick a different index for one of the querires, which led to different test output. Temporarily remove the alternative index to make the test predictible.
The join test could sometimes pick a seqscan+sort instead of an indexscan when doing a MergeAppend+MergeJoin. Disabling seqscan should make it deterministic.
erimatnor
force-pushed
the
hypercore-fix-flaky-tests
branch
from
0b9db39
to
3bdfadf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should fix two Hypercore tests that could sometimes fail due to different query plans.
Disable-check: force-changelog-file
Disable-check: commit-count
Disable-check: approval-count