Rewrite CI to a Modern Standard

[JasonGrace2282]

Motivation

Tin's CI is kind of weak, with a mix of black, autopep8 and isort that requires you to run the script before committing. Instead, we can use tools like pre-commit to auto-run these checks before committing, reducing the mental load on developers. Tin has a primitive form of pre-commit in place, but to utilize the concurrent nature of pre-commit it's better to use different hooks.
Also, the current script being run is very lax, more rules would result in better code quality with less mental load on developers.

TL;DR I hate running scripts.

Revamp CI

• scripts/format.sh
• scripts/check.sh
• Be more strict with style

Linting

• Clean up code

Bonus Request

• Add pre-commit ci to auto push fixes, to automate this kind of thing.

[krishnans2006]

Looks good! A quick question:

[JasonGrace2282]

There seems to be a problem with setup-python, specifically actions/setup-python#436.

[krishnans2006]

Great work! Here are a few things I noticed while just reading over the changes. I'd like to test some of the more suspicious changes to make sure these won't break crucial functionality (even though they shouldn't), so this might not be the full review.

[JasonGrace2282]

Thanks for the review!
Seeing as you added pre-commit.ci (thanks for that btw!) do you want me to just remove ci.yml, remove all the steps from it, or just leave it as it is (after removing the cache, because that failing is annoying)?

[krishnans2006]

Seeing as you added pre-commit.ci (thanks for that btw!) do you want me to just remove ci.yml, remove all the steps from it, or just leave it as it is (after removing the cache, because that failing is annoying)?

You're welcome! It's quite sad that it fails for my hacky format.sh solution - luckily, this PR should fix it.

I think what you do with ci.yml is up to you. I don't think removing all its steps is a great option, but you can either delete it entirely or leave it as it is until we're sure that pre-commit.ci works perfectly.

[JasonGrace2282]

I just went ahead and deleted it entirely :)
Better not to have to worry about pipenv cache causing the tests to fail imo.

[JasonGrace2282]

On second thought, I just had an idea for a script making sure that Pipfile.lock is up-to-date. Maybe that would be a good replacement in the CI.

[krishnans2006]

Great job! Are you good with merging this in, or are you planning more changes?

[JasonGrace2282]

I think I'm good with this!