Deprecate Python 3.6 & 3.7; get CI working again #270

BrianPugh · 2023-04-15T22:40:46Z

Change Log

Dropped python 3.6 and python 3.7 support.
Added python 3.10 and python 3.11 to all the relevant places
Updated pre-commit hooks to latest versions
Replaced deprecated isort flag -sl with current --force-single-line-imports.
Change "extras" dependencies to modern poetry dependency groups.
- Removed all sphinx-related doc dependencies from the main dependency group.
Fixed a few minor typing issues with merge_styles
Explicitly set the prompt_toolkit version to be <=3.0.36 because 3.0.37 has introduced some event-loop-related bug.
make clean will now also clean the docs.

Original Post

What is the problem that this PR addresses?

isort 5.10.1 has the issues described here.

How did you solve it?

Ran pre-commit autoupdate to update all plugins; fixing minor linting issues in changes of Black.

Checklist

I have read the Contributor's Guide.
I will check that all automated PR checks pass before the PR gets reviewed.

kiancross · 2023-04-16T18:21:15Z

Thanks for the PR. It looks like the CI is broken for the repo at the moment. I will have to look into fixing this before I can merge!

BrianPugh · 2023-04-17T02:46:51Z

Seems like issues with some CI running on older python 3.7. I'd recommend dropping support (it's at EOL in 2 months anyways)

kiancross · 2023-05-13T20:56:16Z

@BrianPugh Could you submit a PR to drop support? I cannot approve my own PRs, so would need to wait until another maintainer is available to get it through if I do it...

BrianPugh · 2023-05-14T21:03:46Z

on it 👍

kiancross · 2023-05-15T15:17:57Z

Thanks, much appreciated. Would you be able to submit a separate PR for it?

BrianPugh · 2023-05-15T18:12:17Z

I'm still working on fixing this up, I'll let you know when it's ready. Why the separate PR?

kiancross · 2023-05-15T18:45:10Z

I'm still working on fixing this up, I'll let you know when it's ready. Why the separate PR?

It's good practice to have only one change per PR. It also means the commit history has an entry per change. Finally, it means changes are not missed when the changelog is written.

BrianPugh · 2023-05-15T18:56:29Z

yeah, but in this case it's kind of complicated since CI is broken.

isort version needs to be changed since older versions are broken with poetry.
newer versions of isort that fix this only support >= python3.8.
prior to the completion of this PR, there are typing errors, so CI would break there.
poetry doesn't support python 3.6

So like this could sort of be broken up into multiple PRs, but it'd be a lot more work for basically no benefit since the goal is to get everything working again with community-supported versions of python.

kiancross · 2023-05-15T20:54:01Z

Fair enough. Keep it in this one, and I'll make sure the commit description contains all the changes. Tag me when you're ready for me to review/merge :)

BrianPugh · 2023-05-16T04:01:26Z

@kiancross I think this is getting close to complete. What I've done so far:

Updated pre-commit hooks
Replaced deprecated isort flag.
Updated poetry
- Updated dependency groups to the modern poetry >=1.2.0 format.
Dropped python 3.6 and python 3.7 support.
Added python 3.10 and python 3.11 to all the relevant places
Fixed a few minor typing issues with merge_styles
Explicitly set the prompt_toolkit version to be <=3.0.36 because 3.0.37 has introduced some event-loop-related bug.
make clean will now also clean the docs.

What I can't figure out:

I've never really used intersphinx before, and I'm getting warnings (that get promoted to errors) like:

/Users/brianpugh/projects/questionary/questionary/question.py:docstring of questionary.question.Question:1: WARNING: py:class reference target not found: prompt_toolkit.application.application.Application
/Users/brianpugh/projects/questionary/questionary/prompts/text.py:docstring of questionary.prompts.text.text:33: WARNING: py:class reference target not found: prompt_toolkit.styles.style.Style
/Users/brianpugh/projects/questionary/questionary/prompts/text.py:docstring of questionary.prompts.text.text:41: WARNING: py:class reference target not found: prompt_toolkit.lexers.base.Lexer
/Users/brianpugh/projects/questionary/questionary/prompts/password.py:docstring of questionary.prompts.password.password:35: WARNING: py:class reference target not found: prompt_toolkit.styles.style.Style
/Users/brianpugh/projects/questionary/questionary/prompts/path.py:docstring of questionary.prompts.path.path:24: WARNING: py:class reference target not found: prompt_toolkit.shortcuts.prompt.CompleteStyle
/Users/brianpugh/projects/questionary/questionary/prompts/path.py:docstring of questionary.prompts.path.path:36: WARNING: py:class reference target not found: prompt_toolkit.completion.base.Completer
/Users/brianpugh/projects/questionary/questionary/prompts/path.py:docstring of questionary.prompts.path.path:39: WARNING: py:class reference target not found: prompt_toolkit.styles.style.Style
/Users/brianpugh/projects/questionary/questionary/prompts/confirm.py:docstring of questionary.prompts.confirm.confirm:28: WARNING: py:class reference target not found: prompt_toolkit.styles.style.Style
/Users/brianpugh/projects/questionary/questionary/prompts/select.py:docstring of questionary.prompts.select.select:47: WARNING: py:class reference target not found: prompt_toolkit.styles.style.Style
/Users/brianpugh/projects/questionary/questionary/prompts/rawselect.py:docstring of questionary.prompts.rawselect.rawselect:39: WARNING: py:class reference target not found: prompt_toolkit.styles.style.Style
/Users/brianpugh/projects/questionary/questionary/prompts/checkbox.py:docstring of questionary.prompts.checkbox.checkbox:51: WARNING: py:class reference target not found: prompt_toolkit.styles.style.Style
/Users/brianpugh/projects/questionary/questionary/prompts/autocomplete.py:docstring of questionary.prompts.autocomplete.autocomplete:34: WARNING: py:class reference target not found: prompt_toolkit.completion.base.Completer
/Users/brianpugh/projects/questionary/questionary/prompts/autocomplete.py:docstring of questionary.prompts.autocomplete.autocomplete:45: WARNING: py:class reference target not found: prompt_toolkit.shortcuts.prompt.CompleteStyle
/Users/brianpugh/projects/questionary/questionary/prompts/autocomplete.py:docstring of questionary.prompts.autocomplete.autocomplete:57: WARNING: py:class reference target not found: prompt_toolkit.styles.style.Style

kiancross · 2023-05-16T22:39:12Z

Thanks for all the help. If possible, try to keep the PR as limited in scope as possible (i.e., only what is needed to get CI working again).

I've never really used intersphinx before, and I'm getting warnings (that get promoted to errors) like

Try changing the following URL

questionary/docs/conf.py

Line 36 in 87a891c

    
           "prompt_toolkit": ("https://python-prompt-toolkit.readthedocs.io/en/master/", None),

to

https://python-prompt-toolkit.readthedocs.io/en/3.0.36/

If that doesn't work, I can take a look, but probs won't have time for a couple of weeks.

Another problem we have is that the 3.6 CI runs are marked as required, and I can't overrule this. @tmbo Can you remove all CI requirements from the branch rules for now, and I will provide a list of which ones to add back once all the CI issues are fixed?

BrianPugh · 2023-05-16T22:44:22Z

Thanks for all the help. If possible, try to keep the PR as limited in scope as possible (i.e., only what is needed to get CI working again).

All the changes so far are the minimum necessary to get CI working (outside of just disabling type checking).

Try changing the following URL

That worked! looks like some codecov issues that i should be able to tack in the next day or two.

BrianPugh · 2023-05-19T16:23:45Z

@kiancross so I think this all works, so I'd say approve the workflow to run and we'll see, but I think i tested it about as far as I can from my side.

kiancross · 2023-05-19T23:29:21Z

The MacOS breakage might be because Poetry also needs updating (see #266).

BrianPugh · 2023-05-20T00:10:28Z

updated; the cache might need to be cleared for it to take effect, though.

kiancross

Ok, this is looking good! Thanks for all your help. I've left some comments/questions below. Can you also update the title of this PR to reflect it's current state and provide a list of changes in the description? I will use this for the commit when merging.

.github/workflows/continuous-integration.yml

docs/Makefile

pyproject.toml

questionary/styles.py

kiancross · 2023-05-21T13:32:10Z

Another problem we have is that the 3.6 CI runs are marked as required, and I can't overrule this.

This is sorted now too, so almost ready to merge!

BrianPugh · 2023-05-21T16:03:03Z

my quick todo list (gotta run for now):

Revert the things I said I'd revert.
Update PR title/main description to be up to date with all the changes we made.

BrianPugh · 2023-05-24T21:50:04Z

Finally circled back around on this; @kiancross I believe this is ready for another review!

.github/workflows/continuous-integration.yml

kiancross

All looks good, thanks a lot for all your work!

CRD716 · 2023-10-23T04:53:22Z

Is it possible to support the latest version of prompt_toolkit yet?

stonebig · 2023-11-04T17:19:39Z

maybe it needs prompt-toolkit-3.0.40, not yet released , with this prompt-toolkit/python-prompt-toolkit#1799

Update pre-commit plugins

d9670e2

BrianPugh mentioned this pull request Apr 15, 2023

Implement 'press any key to continue' prompt #271

Merged

2 tasks

BrianPugh force-pushed the update-pre-commit-plugins branch 2 times, most recently from 937eed1 to 2f1b5df Compare May 14, 2023 21:28

drop support for python 3.6, 3.7. Added 3.10 and 3.11

a1b9fe8

BrianPugh force-pushed the update-pre-commit-plugins branch from 2f1b5df to a1b9fe8 Compare May 14, 2023 21:28

BrianPugh added 4 commits May 14, 2023 16:55

fix/ignore typing issues

79b77e8

fix deprecated isort flag

1e3b2ec

misc

3276b2f

typing/linting fix

adfac7f

BrianPugh added 2 commits May 15, 2023 18:19

Specify prompt_toolkit <=3.0.36 to avoid event loop in version 3.0.37

4468bb8

modern poetry dependency groups

dfa8c9c

BrianPugh force-pushed the update-pre-commit-plugins branch from a61f750 to dfa8c9c Compare May 16, 2023 01:49

make clean target now also cleans docs

8a0f1a6

peg prompt-toolkit intersphinx version to 3.0.36

5e1d9b2

fix coveralls upload

24edd17

update github action poetry from v7 to v8

06f1393

kiancross reviewed May 20, 2023

View reviewed changes

kiancross mentioned this pull request May 20, 2023

Remove upper bound from Python version specifier #249

Merged

2 tasks

BrianPugh added 3 commits May 24, 2023 14:42

merge_styles_default docstring.

27a852f

revert poetry build-system requires to poetry-core

79d4380

revert coveralls service job_id and number in CI

bd9674d

BrianPugh changed the title ~~Update pre-commit plugins~~ Deprecate Python 3.6 & 3.7; get CI working again May 24, 2023

kiancross reviewed May 25, 2023

View reviewed changes

.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved

Update .github/workflows/continuous-integration.yml

53af550

kiancross approved these changes May 25, 2023

View reviewed changes

kiancross merged commit 6cdc221 into tmbo:master May 25, 2023

kiancross added a commit to kiancross/questionary that referenced this pull request Jun 30, 2023

Fix bug in Makefile introduced in tmbo#270

531414a

kiancross mentioned this pull request Jun 30, 2023

Fix bug in Makefile introduced in #270 #291

Merged

2 tasks

kiancross added a commit to kiancross/questionary that referenced this pull request Jun 30, 2023

Fix bug in Makefile introduced in tmbo#270

6e98c49

kiancross mentioned this pull request Jun 30, 2023

CI should use Makefile targets, to ensure these are tested #292

Open

kiancross added a commit that referenced this pull request Jun 30, 2023

Fix bug in Makefile introduced in #270 (#291)

075a291

kiancross mentioned this pull request Jul 25, 2023

Add changelog and bump version to 2.0.0 #300

Merged

2 tasks

fcollonval mentioned this pull request Sep 8, 2023

Align prompt_toolkit constrain conda-forge/questionary-feedstock#7

Merged

4 tasks

CRD716 mentioned this pull request Oct 23, 2023

Update requirements in preparation for 3.12 Pythagora-io/gpt-pilot#271

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate Python 3.6 & 3.7; get CI working again #270

Deprecate Python 3.6 & 3.7; get CI working again #270

BrianPugh commented Apr 15, 2023 •

edited

Loading

kiancross commented Apr 16, 2023

BrianPugh commented Apr 17, 2023

kiancross commented May 13, 2023 •

edited

Loading

BrianPugh commented May 14, 2023

kiancross commented May 15, 2023

BrianPugh commented May 15, 2023

kiancross commented May 15, 2023

BrianPugh commented May 15, 2023

kiancross commented May 15, 2023

BrianPugh commented May 16, 2023

kiancross commented May 16, 2023

BrianPugh commented May 16, 2023

BrianPugh commented May 19, 2023

kiancross commented May 19, 2023

BrianPugh commented May 20, 2023

kiancross left a comment

kiancross commented May 21, 2023

BrianPugh commented May 21, 2023

BrianPugh commented May 24, 2023

kiancross left a comment

CRD716 commented Oct 23, 2023

stonebig commented Nov 4, 2023

Deprecate Python 3.6 & 3.7; get CI working again #270

Deprecate Python 3.6 & 3.7; get CI working again #270

Conversation

BrianPugh commented Apr 15, 2023 • edited Loading

Change Log

Original Post

kiancross commented Apr 16, 2023

BrianPugh commented Apr 17, 2023

kiancross commented May 13, 2023 • edited Loading

BrianPugh commented May 14, 2023

kiancross commented May 15, 2023

BrianPugh commented May 15, 2023

kiancross commented May 15, 2023

BrianPugh commented May 15, 2023

kiancross commented May 15, 2023

BrianPugh commented May 16, 2023

kiancross commented May 16, 2023

BrianPugh commented May 16, 2023

BrianPugh commented May 19, 2023

kiancross commented May 19, 2023

BrianPugh commented May 20, 2023

kiancross left a comment

Choose a reason for hiding this comment

kiancross commented May 21, 2023

BrianPugh commented May 21, 2023

BrianPugh commented May 24, 2023

kiancross left a comment

Choose a reason for hiding this comment

CRD716 commented Oct 23, 2023

stonebig commented Nov 4, 2023

BrianPugh commented Apr 15, 2023 •

edited

Loading

kiancross commented May 13, 2023 •

edited

Loading