Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout broken #737

Closed
pogopaule opened this issue Feb 20, 2022 · 6 comments
Closed

Layout broken #737

pogopaule opened this issue Feb 20, 2022 · 6 comments
Labels
bug Something isn't working p4-important ❗ Violate documented behavior or significantly improves performance (priority)

Comments

@pogopaule
Copy link

Step 1: Provide a summary of your problem

Using the configuration from https://tmuxp.git-pull.com/examples.html#short-hand-inline I get the following tmux
image

Step 2: Provide tmuxp details

-------------------------
environment:
	dist: Linux-5.4.0-100-generic-x86_64-with-glibc2.29
	arch: x86_64
	uname: Linux; pogopaule-ThinkPad-T550; 5.4.0-100-generic
	version: #113-Ubuntu SMP Thu Feb 3 18:43:29 UTC 2022
-------------------------
python version: 3.8.10 (default, Nov 26 2021, 20:14:08)  [GCC 9.3.0]
system PATH: Now using node v16.13.0 (npm v8.1.0)
/home/pogopaule/.yarn/bin:/home/pogopaule/bin:/usr/local/bin:/home/pogopaule/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/usr/local/go/bin
tmux version: 3.0
libtmux version: 0.10.3
tmuxp version: 1.9.4
tmux path: /usr/bin/tmux
tmuxp path: /home/pogopaule/.local/lib/python3.8/site-packages/tmuxp/__init__.py
shell: /usr/bin/zsh
-------------------------
tmux sessions:

	no server running on /tmp/tmux-1000/default
tmux windows:

	no server running on /tmp/tmux-1000/default
tmux panes:

	no server running on /tmp/tmux-1000/default
tmux global options:

	no server running on /tmp/tmux-1000/default
tmux window options:

	no server running on /tmp/tmux-1000/default

Step 3: Describe the problem:

Steps to reproduce:

  1. pip3 install --user tmuxp
  2. create yaml file with https://tmuxp.git-pull.com/examples.html#short-hand-inline as content
  3. run tmuxp load config.yaml

Observed Results:

See image above with broken layout and output in just one pane

Expected Results:

A layout with equal space for each of the three panes and output in each of them.

Relevant Code:

My configuration https://github.com/pogopaule/dotfiles/

@tony
Copy link
Member

tony commented Feb 20, 2022

I get the same result. it's scrunched together.

This needs to get looked at

@tony tony added the bug Something isn't working label Feb 20, 2022
@tony tony added the p4-important ❗ Violate documented behavior or significantly improves performance (priority) label May 21, 2022
@tony
Copy link
Member

tony commented May 21, 2022

Upgrading this to p4-important @pogopaule

FYI: I may close or merge this into other issues - depending on if there's an earlier one with the same root cause. I'm not quite sure yet. I will keep you apprised

@tony tony added this to the Milestone 1.12 milestone May 21, 2022
nvasilas added a commit to nvasilas/tmuxp that referenced this issue Aug 7, 2022
…on#704

Use tmux default session size 80x24 when creating a new session
tony pushed a commit to nvasilas/tmuxp that referenced this issue Aug 14, 2022
…on#704

Use tmux default session size 80x24 when creating a new session
tony pushed a commit to nvasilas/tmuxp that referenced this issue Aug 21, 2022
…on#704

Use tmux default session size 80x24 when creating a new session
@tony tony closed this as completed in 129300d Aug 21, 2022
@tony
Copy link
Member

tony commented Aug 21, 2022

@pogopaule @tutuca

v1.13.1 is live with a fix, via @nvasilas from #793

PyPI, GitHub Tag

pip install tmuxp==1.13.1

Any better now?

P.S. You may need to kill your tmux server or try on a fresh one by passing something like tmuxp ./workspacefile.yaml -L OtherTmuxServer

tony added a commit that referenced this issue Sep 10, 2022
This may negate the fix from #737 (for #667 and #704)
that helped certain layouts.

If a client hasn't yet been attached, 80x24 isn't enough 
to handle workspace building splitting the panes out.
@tony
Copy link
Member

tony commented Sep 10, 2022

My next change at v1.13.2 will probably bring this issue back, if so ping me.

tony added a commit that referenced this issue Sep 10, 2022
tony added a commit that referenced this issue Sep 10, 2022
@tony
Copy link
Member

tony commented Apr 7, 2024

@pogopaule @tutuca

There is a PR at #926 testing a fix.

If you try these instructions, does this help?

tony added a commit that referenced this issue Apr 7, 2024
@tony
Copy link
Member

tony commented Apr 13, 2024

If you try v1.46.0 (docs, changes, release, PyPI), is anything better?

Instructions:

pip install --user --upgrade tmuxp

tmuxp -V should show at least 1.46.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p4-important ❗ Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

No branches or pull requests

2 participants