-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder: Use shutil.get_terminal_size()
#926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #926 +/- ##
==========================================
- Coverage 70.28% 70.19% -0.09%
==========================================
Files 26 26
Lines 1955 1936 -19
Branches 409 404 -5
==========================================
- Hits 1374 1359 -15
Misses 454 454
+ Partials 127 123 -4 ☔ View full report in Codecov by Sentry. |
tony
force-pushed
the
builder-sizes
branch
2 times, most recently
from
April 7, 2024 16:44
3f076f9
to
07a45ab
Compare
This was referenced Apr 7, 2024
Closed
tony
added a commit
that referenced
this pull request
Apr 7, 2024
tony
added a commit
that referenced
this pull request
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in re: #667, #704, #737
Warning
This would definitely be breaking behavior.
Test instructions
Latest (1.46.0a0):
pipx install --suffix=@builder-sizes 'tmuxp >= 1.46.0a0'
Outdated:
pipx install --suffix=@builder-sizes 'tmuxp @ git+https://github.com/tmux-python/tmuxp.git@builder-sizes'
Then:
tmuxp@builder-sizes load ./path/to/file.yaml
In the configuration, use
options.main-pane-height
/options.main-pane-width
with or without percentage:You should see something like:
Video:
2024-04-07.12-38-33.-.tmuxp.-.pr.926.-.main-pane-height.mp4
Changes
[Builder] Use
shutil.get_terminal_size
This ensures the tmux builder obeys the terminal window's current dimensions.
CLI[Load] Remove layout hooks
These did not seem to be implemented correctly anyway, so will effectively be a noop.