feat: Provide capability to use multiple metric dimensions #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review it as soon as possible. |
|
The scraper tests fail because of OTEL metrics and indeed I don't see any metrics in Show Prometheus metrics for OpenTelemetry agent. @tomkerkhove, since the integration tests all run successfully for me locally, would you mind rerunning the test to see if it's a transient issue? |
|
/azp run Promitor CI - Scraper Agent |
|
No commit pushedDate could be found for PR 2351 in repo tomkerkhove/promitor |
|
Looks like it was indeed a transient issue, since it's all green now 😄 |
|
Can you open a companion PR for the docs please? |
|
I was going to but noticed it's already supported according to the docs 😄 promitor/docs#38 |
|
Woops, that already got merged |
trafico-bot
bot
added
✨ Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1820
Based on #2123 (thanks @aaronweissler and @Patrick-Eichhorn!)