Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide capability to use multiple metric dimensions #2351

Merged
merged 56 commits into from
Jul 20, 2023
Merged

feat: Provide capability to use multiple metric dimensions #2351

merged 56 commits into from
Jul 20, 2023

Commits on Nov 14, 2022

  1. WIP Use multiple MetricDimensions

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    13ea14a View commit details
    Browse the repository at this point in the history

  2. WIP use multiple metric dimensions

    @Patrick-Eichhorn @aaronweissler
    Patrick-Eichhorn authored and aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    fdb5590 View commit details
    Browse the repository at this point in the history

  3. Add Deserialization for List of Dimensions

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    3f52b6a View commit details
    Browse the repository at this point in the history

  4. Add backwards compatibility to deserialization

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    e08f48f View commit details
    Browse the repository at this point in the history

  5. Remove old Dimension attribute

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    1e2e998 View commit details
    Browse the repository at this point in the history

  6. Change Log message

    @Patrick-Eichhorn @aaronweissler
    Patrick-Eichhorn authored and aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    573554a View commit details
    Browse the repository at this point in the history

  7. WIP add support for multiple dimensions

    @Patrick-Eichhorn @aaronweissler
    Patrick-Eichhorn authored and aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    6df4f89 View commit details
    Browse the repository at this point in the history

  8. Fix and Add Serialization Test

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    b997736 View commit details
    Browse the repository at this point in the history

  9. Add parameter docs

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    399978e View commit details
    Browse the repository at this point in the history

  10. Fix PrometheusScrapingEndpointMetricSinkTests

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    ef0a44b View commit details
    Browse the repository at this point in the history

  11. Use var instead of int on IDE recommendation

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    0b08cd4 View commit details
    Browse the repository at this point in the history

  12. Fix IDE recommendations

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    05cbac3 View commit details
    Browse the repository at this point in the history

  13. Add comment

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    5fb9cf5 View commit details
    Browse the repository at this point in the history

  14. Remove unneeded imports

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    6a9a6f0 View commit details
    Browse the repository at this point in the history

  15. Add changelog

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    b2dc857 View commit details
    Browse the repository at this point in the history

  16. Add second dimension to example metric

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    2bf1128 View commit details
    Browse the repository at this point in the history

  17. Add missing docstring

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    64c201d View commit details
    Browse the repository at this point in the history

  18. Add HasDimensions method to remove code duplicate

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    fb75905 View commit details
    Browse the repository at this point in the history

  19. Combine dimensionNames and dimensionValues in List

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    a96fbb3 View commit details
    Browse the repository at this point in the history

  20. Refactor method names to plural for dimensions

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    4cdd2c4 View commit details
    Browse the repository at this point in the history

  21. Removed unused using directives

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    171392d View commit details
    Browse the repository at this point in the history

  22. Fix changelog linting errors

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    839de64 View commit details
    Browse the repository at this point in the history

  23. Add support for YamlSequenceNodes in Deserializers

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    4e48149 View commit details
    Browse the repository at this point in the history

  24. Re-add Dimension field and move consolidation

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    edc0e47 View commit details
    Browse the repository at this point in the history

  25. Update MetricsDeclarationBuilder

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    b0d8074 View commit details
    Browse the repository at this point in the history

  26. Add AzureMetricConfigurationValidator Tests

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    693143b View commit details
    Browse the repository at this point in the history

  27. Fix HasDimension for re-added Dimension field

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    9ca0996 View commit details
    Browse the repository at this point in the history

  28. Fail validation for MessagingScrapers if more than one dimension is d… 

    …efined
    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    91f15a7 View commit details
    Browse the repository at this point in the history

  29. Fix linting errors

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    ea6507d View commit details
    Browse the repository at this point in the history

  30. Specify properties more exactly in changelog

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    19faf9a View commit details
    Browse the repository at this point in the history

  31. Add Distinct to DetermineMetricDimensions

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    e321e9f View commit details
    Browse the repository at this point in the history

  32. Fix Resharper warnings

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    4bae988 View commit details
    Browse the repository at this point in the history

  33. Fix AzureMetricConfigurationValidator tests

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    dbb26c5 View commit details
    Browse the repository at this point in the history

  34. Remove unneeded using

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    35dce63 View commit details
    Browse the repository at this point in the history

  35. Re-add obsolete and add exclusion for resharper

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    5d499ff View commit details
    Browse the repository at this point in the history

  36. Add warning exception to remaining projects

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    85f069d View commit details
    Browse the repository at this point in the history

  37. Suppress warning for IDeserializer

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    af0370c View commit details
    Browse the repository at this point in the history

  38. Add test for dimensions

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    7a3a1ba View commit details
    Browse the repository at this point in the history

  39. WIP disable new test

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    ec53834 View commit details
    Browse the repository at this point in the history

  40. Apply suggestions from code review 

    Co-authored-by: Tom Kerkhove <[email protected]>
    @aaronweissler @tomkerkhove
    aaronweissler and tomkerkhove committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    69f0762 View commit details
    Browse the repository at this point in the history

  41. Add suggestion

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    c558f1a View commit details
    Browse the repository at this point in the history

  42. Simplify arrange of ConfigurationValidatorTests

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    d18362a View commit details
    Browse the repository at this point in the history

  43. Make return type of HasDimension nullable

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    5fe7f98 View commit details
    Browse the repository at this point in the history

  44. Add dimension names to ConfigurationValidatorTest

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    4999b23 View commit details
    Browse the repository at this point in the history

  45. WIP add new metrics with dimensions in metrics.yaml

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    19faf8c View commit details
    Browse the repository at this point in the history

  46. Remove old example of dimensions from metrics.yaml

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    b933ab8 View commit details
    Browse the repository at this point in the history

  47. Modify and unskip dimensions integration test

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    9a3a487 View commit details
    Browse the repository at this point in the history

  48. Fix trailing space in metrics.yaml

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    56f8efd View commit details
    Browse the repository at this point in the history

  49. Add missing sanitization in dimensions integration test

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    fa4380e View commit details
    Browse the repository at this point in the history

  50. sanitize only once in dimensions integration test

    @aaronweissler
    aaronweissler committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    2c4db50 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Merge branch 'master' into feature/multiple-dimensions

    @tomkerkhove
    tomkerkhove authored Mar 18, 2023
    Configuration menu
    Copy the full SHA
    2335606 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Merge branch 'master' into feature/multiple-dimensions

    @amirschw
    amirschw committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    a350f89 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/multiple-dimensions

    @amirschw
    amirschw committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    4ca0710 View commit details
    Browse the repository at this point in the history

  3. fix integration tests

    @amirschw
    amirschw committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    fb4d6b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. fix integration tests failing due to otel name length limit

    @amirschw
    amirschw committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    439d6cc View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Merge branch 'master' into feature/multiple-dimensions

    @amirschw
    amirschw committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    1a72459 View commit details
    Browse the repository at this point in the history