Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(descriptions): expand information for key and code #318

Open
wants to merge 1 commit into
base: main-legacy
Choose a base branch
from
Open

feat(descriptions): expand information for key and code #318

wants to merge 1 commit into from

Conversation

cwadrupldijjit
Copy link
Contributor

What Changed?

  • add more explanations about behavior of .key and .code event properties
  • remove extraneous parentheses surrounding deprecated
  • add cross-env to allow for Windows users to run the app with the node options supplied in the env

Issues Addressed:

  • N/A

Issue Testing:

  • Manual Developer Testing

Test Results:

  1. Open browser to running application
  2. Read the descriptions on the page for the .key and .code values
  3. See that they add clarity to the behavior of their respective properties

@cwadrupldijjit
feat(descriptions): expand information for key and code
4399d7f 
### What Changed?
- add more explanations about behavior of `.key` and `.code` event properties
- add `cross-env` to allow for Windows users to run the app with the node options supplied in the env

### Issues Addressed:
- N/A

### Issue Testing:
- Manual Developer Testing

### Test Results:
1. Open browser to running application
1. Read the descriptions on the page for the `.key` and `.code` values
1. See that they add clarity to the behavior of their respective properties
@cwadrupldijjit cwadrupldijjit requested a review from a team as a code owner May 2, 2022 20:16
@cwadrupldijjit cwadrupldijjit requested review from macap and afzaalahmad and removed request for a team May 2, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macap macap Awaiting requested review from macap macap was automatically assigned from toptal/marketing-tools-2-eng

@afzaalahmad afzaalahmad Awaiting requested review from afzaalahmad afzaalahmad was automatically assigned from toptal/marketing-tools-2-eng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cwadrupldijjit