Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(descriptions): expand information for key and code #318

Open
wants to merge 1 commit into
base: main-legacy
Choose a base branch
from
+35 −4
Open

feat(descriptions): expand information for key and code #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "![](http://wes.io/sQyC/content.gif)",
"main": "google-analytics.js",
"scripts": {
"dev": "NODE_OPTIONS='--inspect' next dev -p 3000",
"dev": "cross-env NODE_OPTIONS='--inspect' next dev -p 3000",
"build": "next build",
"start": "next start"
},
Expand Down Expand Up @@ -37,6 +37,7 @@
},
"devDependencies": {
"babel-eslint": "^10.1.0",
"cross-env": "^7.0.3",
"eslint": "^8.11.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-prettier": "^8.5.0",
Expand Down
8 changes: 5 additions & 3 deletions pages/for/[key].js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ export default function HomePage({ staticKey }) {
<footer>
<p>
The value of the key pressed. Accounts for modifiers keys that
return CAPS and alternate chars.
return CAPS and alternate chars. Also respects different
keyboard layouts.
</p>
</footer>
</div>
Expand Down Expand Up @@ -131,7 +132,8 @@ export default function HomePage({ staticKey }) {
<footer>
<p>
The physical key on the keyboard. Doesn't care if you are
holding a modifier like Shift.
holding a modifier like Shift. Only reports the key's physical
location in a US standard QWERTY layout.
</p>
</footer>
</div>
Expand All @@ -148,7 +150,7 @@ export default function HomePage({ staticKey }) {
target="_blank"
rel="noopener noreferrer"
>
(deprecated)
deprecated
</a>{' '}
in modern browsers. Use <code>.key</code> or <code>.code</code>{' '}
instead.
Expand Down