fix: setWindowState when target_space is empty #2
Conversation
shailesh17
commented
Nov 3, 2024
shailesh17
commented
- Fix crash when target space is empty during setting of window state
- also adding default excludes for vscode editor in .gitignore
There was a problem hiding this comment.
Hi @shailesh17, thanks for the support! Good bug-catch! I added a minor modification suggestion to your request.
shailesh17
changed the title
There was a problem hiding this comment.
hey @shailesh17, thanks again for the support;
unfortunately testing the code after your changes leads to a bit of a bug, so another modification is needed
| rs.delayExecution(0.4) | ||
| window:moveToScreen(target_screen) | ||
| window:focus() | ||
| rs.issueVerbose("target space undefined; unable to set window " .. window:id(), rs.verbose) | ||
| end | ||
|
|
||
| rs.setFrameState(window, frame_state, fullscreen_state) |
There was a problem hiding this comment.
this does not comply with the modifications...
both setFrameState and issueVerbose("set window"...) should only be called if target_space was identified, so they should be moved into the if statement (or maybe using a return)
There was a problem hiding this comment.
Since you're at it, can you also try to change the "target space undefined..." line to keep it under 72 characters?
In this code I have been using something like the following:
local msg = "target space undefined; "
msg = msg .. "unable to set window "
rs.issueVerbose(msg .. window:id(), rs.verbose)
