Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-import] feat: grey out non imported columns #692

Open
wants to merge 1 commit into
base: releaseCandidate
Choose a base branch
from

Conversation

kaustubhdapurkar
Copy link

@kaustubhdapurkar kaustubhdapurkar commented Dec 28, 2024

Describe your changes

Grey's out columns that were not imported during data import

chrome_X5WSlPXUZO.mp4

Issue ticket number and link

Issue Ticket Number - 507
Link - #507

Checklist before requesting a review

  • I have read and understand the Contributions section
  • Target branch is releaseCandidate and not master
  • I have performed a self-review of my code
  • I ran the unit tests and my PR does not break any tests
  • I documented the changes I've made on the CHANGES.md and followed actual conventions
  • I added a new section on how-to.md (optional)

* grey out non imported columns

* updated changes.md
@tprouvot
Copy link
Owner

tprouvot commented Jan 9, 2025

Thanks for the PR @kaustubhdapurkar !
I'll take a look at it next week

@tprouvot
Copy link
Owner

tprouvot commented Jan 9, 2025

@kaustubhdapurkar Few remarks concerning the design, I think that only grey out the header columns should be enough.
The fields name in the Field Mapping section are not greyed out.

Since this is a visual change and not all the users may want it, I would add a new option to enable this feature or not

@tprouvot tprouvot changed the title Feat/grey out non imported columns (#1) [data-import] feat: grey out non imported columns Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants